sql: remove local option to SET TRACING
#57567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
approved these changes
Dec 4, 2020
The `local` option creates a recording span whose child spans are not recording. We weren't meaningfully using it, and it adds cognitive overhead, so remove it. Closes cockroachdb#55585. Closes cockroachdb#55586. Release note (sql change): The "local" option to `SET TRACING` was removed.
tbg
force-pushed
the
tracing-remove-local-mode
branch
from
b3b30d1
to
ad3c30c
Compare
|
TFTR! Fixed CI (had to update some tests and remove unused code). bors r=knz |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
localoption creates a recording span whose child spansare not recording. We weren't meaningfully using it, and it
adds cognitive overhead, so remove it.
Closes #55585.
Closes #55586.
Release note (sql change): The "local" option to
SET TRACINGwasremoved.