release-20.2: sql: fix crash with deletes in edge cases #58266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Dec 24, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
The `execFactory` itself computes the set of columns to fetch during the DELETE operation. Previously, this was enforced by slicing up the internal `FetchCols` slice of the `Deleter`. However, there is another internal slice `FetchColIDtoRowIndex` that must be kept in sync with `FetchCols`, and this was forgotten. This commit fixes this issue and refactors the code slightly to be more explicit on how those slices are populated. Release note (bug fix): Previously, CockroachDB could crash when performing a DELETE operation after an alteration of the primary key when in some cases, and now it is fixed. The bug was introduced in 20.1 version.
yuzefovich
force-pushed
the
backport20.2-58153
branch
from
176dd3b
to
135683e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #58153.
/cc @cockroachdb/release
The
execFactoryitself computes the set of columns to fetch during theDELETE operation. Previously, this was enforced by slicing up the
internal
FetchColsslice of theDeleter. However, there is anotherinternal slice
FetchColIDtoRowIndexthat must be kept in sync withFetchCols, and this was forgotten. This commit fixes this issue andrefactors the code slightly to be more explicit on how those slices are
populated.
Fixes: #54629.
Release note (bug fix): Previously, CockroachDB could crash when
performing a DELETE operation after an alteration of the primary key
when in some cases, and now it is fixed. The bug was introduced in 20.1
version.