Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-20.2: sql: fix crash with deletes in edge cases #58266

Merged
merged 1 commit into from
Dec 25, 2020
Merged

release-20.2: sql: fix crash with deletes in edge cases #58266

merged 1 commit into from
Dec 25, 2020

Commits on Dec 24, 2020

  1. sql: fix crash with deletes in edge cases 

    The `execFactory` itself computes the set of columns to fetch during the
DELETE operation. Previously, this was enforced by slicing up the
internal `FetchCols` slice of the `Deleter`. However, there is another
internal slice `FetchColIDtoRowIndex` that must be kept in sync with
`FetchCols`, and this was forgotten. This commit fixes this issue and
refactors the code slightly to be more explicit on how those slices are
populated.

Release note (bug fix): Previously, CockroachDB could crash when
performing a DELETE operation after an alteration of the primary key
when in some cases, and now it is fixed. The bug was introduced in 20.1
version.
    @yuzefovich
    yuzefovich committed Dec 24, 2020
    Configuration menu
    Copy the full SHA
    135683e View commit details
    Browse the repository at this point in the history