sql: fix assertion failure for CREATE TABLE with duplicate index names #58433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, since version 20.2, executing a statement such as ``` CREATE TABLE t (a INT, b INT, INDEX idx (a), INDEX idx (b)) ``` yields an assertion failure during the validation of the table descriptor. This is a regression from version 20.1 which yields a proper error: ``` ERROR: duplicate index name: "idx" ``` This patch fixes this regression and restores the original behaviour. Fixes cockroachdb#57630. Release note (bug fix): A CREATE TABLE statement with indexes with duplicate names will no longer result in an assertion failure. This bug was present since version 20.2.
|
This change is |
ajwerner
approved these changes
Jan 4, 2021
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, since version 20.2, executing a statement such as
yields an assertion failure during the validation of the table descriptor.
This is a regression from version 20.1 which yields a proper error:
This patch fixes this regression and restores the original behaviour.
Fixes #57630.
Release note (bug fix): A CREATE TABLE statement with indexes with
duplicate names will no longer result in an assertion failure. This bug
was present since version 20.2.