release-20.2: sql: make schema change jobs for databases and schemas non-cancelable #61254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
Schema change jobs to drop, rename, or change privileges on databases and schemas cannot be meaningfully reverted, because they just wait for leases to drain, or handle draining names when applicable. Currently, if we ever enter `OnFailOrCancel` for a schema change job on a database or schema, we return with an error. This PR reduces the risk of this happening by disallowing cancelation of these jobs. Release note (bug fix): Schema change jobs associated with databases and schemas can no longer be canceled. Such jobs cannot actually be reverted successfully, so cancelation had no benefit and could have caused namespace corruption.
thoszhang
force-pushed
the
backport20.2-61210
branch
from
962943f
to
7674d5b
Compare
|
Ran into #58353. I also had to add a few extra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #61210.
/cc @cockroachdb/release
Schema change jobs to drop, rename, or change privileges on databases
and schemas cannot be meaningfully reverted, because they just wait for
leases to drain, or handle draining names when applicable. Currently, if
we ever enter
OnFailOrCancelfor a schema change job on a database orschema, we return with an error. This PR reduces the risk of this
happening by disallowing cancelation of these jobs.
Partially addresses #59545.
Release note (bug fix): Schema change jobs associated with databases and
schemas can no longer be canceled. Such jobs cannot actually be reverted
successfully, so cancelation had no benefit and could have caused
namespace corruption.