sql: minor fixes to fix panics related to type resolution and bad planner usage #65108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This further paper's over the rough edges of not resetting the planner state to keep it in sync with the connExecutor state. The test used to panic before this change. Touches cockroachdb#64140. Release note (bug fix): Fixed a bug which could cause a panic when running a EXECUTE of a previously PREPARE'd statement with a REGCLASS, REGTYPE parameter or a user-defined type argument after running BEGIN AS OF SYSTEM TIME with an invalid timestamp.
Before this change we'd resolve user-defined types into placeholder hints using a planner which may not be in a valid state. This could result in a nil-pointer panic. I don't actually know how to trigger this from a driver but there's evidence that it's possible. It's easy enough to hit using SQL if the previous commit were not here. Fixes cockroachdb#64975 Release note (bug fix): Fixed a bug which could cause a panic when issuing a query referencing a user-defined type as a placeholder.
|
This change is |
|
@andreimatei maybe you have something to say about this. |
otan
approved these changes
May 13, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 3 of 3 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @rafiss)
|
TFTR! bors r=otan |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits. The first commit matters but does not leave one with a good feeling. The second one is more copacetic.
Relates to #64140.
Fixes #64975.
Release note (bug fix): Fixed a bug which could cause a panic when
running a EXECUTE of a previously PREPARE'd statement with a REGCLASS,
REGTYPE parameter or a user-defined type argument after running BEGIN
AS OF SYSTEM TIME with an invalid timestamp.
Release note (bug fix): Fixed a bug which could cause a panic when issuing
a query referencing a user-defined type as a placeholder as the first operation
on a new connection.