sql/catalog: v20.2.9: nil txn or mutex when resolving type

[cockroach-teamcity]

This issue was autofiled by Sentry. It represents a crash or reported error on a live cluster with telemetry enabled.

Sentry link: https://sentry.io/organizations/cockroach-labs/issues/2392749777/?referrer=webhooks_plugin

Panic message:

conn_executor.go:506: runtime error: invalid memory address or nil pointer dereference
--
runtime.errorString
conn_executor.go:506: *withstack.withStack (top exception)
*safedetails.withSafeDetails: while executing: SELECT ., ., ., ., ., ., ., ., ., ., ., ., ., ., ., ., ., ., ., ., . FROM _ AS _ WHERE ((((. = $1) AND ((($2 = ) AND (._ IS DISTINCT FROM )) OR (._ = ANY ($3)))) AND (. = $4)) AND (. = $5)) AND (. = ANY ($6)) (1)
conn_executor.go:506: *withstack.withStack (2)
(check the extra data payloads)

Stacktrace (expand for inline code snippets):

cockroach/pkg/sql/conn_executor.go

Lines 505 to 507 in c9d5466

	r := recover()
	h.ex.closeWrapper(ctx, r)
	}()

in pkg/sql.(*Server).ServeConn.func1
/usr/local/go/src/runtime/panic.go#L678-L680 in runtime.gopanic
/usr/local/go/src/runtime/panic.go#L198-L200 in runtime.panicmem
/usr/local/go/src/runtime/signal_unix.go#L393-L395 in runtime.sigpanic
/usr/local/go/src/sync/mutex.go#L73-L75 in sync.(*Mutex).Lock

cockroach/pkg/kv/txn.go

Lines 284 to 286 in c9d5466

	func (txn *Txn) ReadTimestamp() hlc.Timestamp {
	txn.mu.Lock()
	defer txn.mu.Unlock()

in pkg/kv.(*Txn).ReadTimestamp

cockroach/pkg/sql/catalog/descs/collection.go

Lines 949 to 951 in c9d5466

	readTimestamp := txn.ReadTimestamp()
	desc, expiration, err := tc.leaseMgr.Acquire(ctx, readTimestamp, id)

in pkg/sql/catalog/descs.(*Collection).getDescriptorVersionByID

cockroach/pkg/sql/catalog/descs/collection.go

Lines 1405 to 1407 in c9d5466

	) (*typedesc.Immutable, error) {
	desc, err := tc.getDescriptorVersionByID(ctx, txn, typeID, flags.CommonLookupFlags, true /* setTxnDeadline */)
	if err != nil {

in pkg/sql/catalog/descs.(*Collection).GetTypeVersionByID

cockroach/pkg/sql/resolver.go

Lines 259 to 261 in c9d5466

	) (tree.TypeName, catalog.TypeDescriptor, error) {
	desc, err := p.Descriptors().GetTypeVersionByID(ctx, p.txn, id, tree.ObjectLookupFlagsWithRequired())
	if err != nil {

in pkg/sql.(*planner).GetTypeDescriptor

cockroach/pkg/sql/resolver.go

Lines 313 to 315 in c9d5466

	func (p *planner) ResolveTypeByOID(ctx context.Context, oid oid.Oid) (*types.T, error) {
	name, desc, err := p.GetTypeDescriptor(ctx, typedesc.UserDefinedTypeOIDToID(oid))
	if err != nil {

in pkg/sql.(*planner).ResolveTypeByOID

cockroach/pkg/sql/conn_executor_prepare.go

Lines 67 to 69 in c9d5466

	var err error
	parseCmd.TypeHints[i], err = ex.planner.ResolveTypeByOID(ctx, parseCmd.RawTypeHints[i])
	if err != nil {

in pkg/sql.(*connExecutor).execPrepare

cockroach/pkg/sql/conn_executor.go

Lines 1550 to 1552 in c9d5466

	stmtCtx := withStatement(ctx, ex.curStmt)
	ev, payload = ex.execPrepare(stmtCtx, tcmd)
	case DescribeStmt:

in pkg/sql.(*connExecutor).execCmd

cockroach/pkg/sql/conn_executor.go

Lines 1390 to 1392 in c9d5466

	var err error
	if err = ex.execCmd(ex.Ctx()); err != nil {
	if errors.IsAny(err, io.EOF, errDrainingComplete) {

in pkg/sql.(*connExecutor).run

cockroach/pkg/sql/conn_executor.go

Lines 507 to 509 in c9d5466

	}()
	return h.ex.run(ctx, s.pool, reserved, cancel)
	}

in pkg/sql.(*Server).ServeConn

cockroach/pkg/sql/pgwire/conn.go

Lines 625 to 627 in c9d5466

	reservedOwned = false // We're about to pass ownership away.
	retErr = sqlServer.ServeConn(ctx, connHandler, reserved, cancelConn)
	}()

in pkg/sql/pgwire.(*conn).processCommandsAsync.func1
/usr/local/go/src/runtime/asm_amd64.s#L1356-L1358 in runtime.goexit

pkg/sql/conn_executor.go in pkg/sql.(*Server).ServeConn.func1 at line 506
/usr/local/go/src/runtime/panic.go in runtime.gopanic at line 679
/usr/local/go/src/runtime/panic.go in runtime.panicmem at line 199
/usr/local/go/src/runtime/signal_unix.go in runtime.sigpanic at line 394
/usr/local/go/src/sync/mutex.go in sync.(*Mutex).Lock at line 74
pkg/kv/txn.go in pkg/kv.(*Txn).ReadTimestamp at line 285
pkg/sql/catalog/descs/collection.go in pkg/sql/catalog/descs.(*Collection).getDescriptorVersionByID at line 950
pkg/sql/catalog/descs/collection.go in pkg/sql/catalog/descs.(*Collection).GetTypeVersionByID at line 1406
pkg/sql/resolver.go in pkg/sql.(*planner).GetTypeDescriptor at line 260
pkg/sql/resolver.go in pkg/sql.(*planner).ResolveTypeByOID at line 314
pkg/sql/conn_executor_prepare.go in pkg/sql.(*connExecutor).execPrepare at line 68
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).execCmd at line 1551
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).run at line 1391
pkg/sql/conn_executor.go in pkg/sql.(*Server).ServeConn at line 508
pkg/sql/pgwire/conn.go in pkg/sql/pgwire.(*conn).processCommandsAsync.func1 at line 626
/usr/local/go/src/runtime/asm_amd64.s in runtime.goexit at line 1357

Tag	Value
Cockroach Release	v20.2.9
Cockroach SHA:	c9d5466
Platform	linux amd64
Distribution	CCL
Environment	v20.2.9
Command	start-single-node
Go Version	``
# of CPUs
# of Goroutines

[ajwerner]

The root cause here is #64140. I'm going to close this as duplicating that issue. @fqazi noted that just a week ago in #64140 (comment).