release-21.1: backupccl: include dropped databases in cluster backups with rev history #65314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
Previously, cluster backups taken with revision_history would not include a database descriptor if it was dropped at the time of the backup. This patch ensures that these database descriptors are picked up by the backup and can therefore be restored with an AOST restore. This bug appeared because backup incorrectly assumed that dropped descriptors remained in the DROP state until their GC TTL. This is not the case for database descriptors which are immedately deleted. Release note (bug fix): Previously revision_history cluster backups would not include dropped databases. This means that dropped databases could not be restored from backups that were taken after the database was dropped.
|
This change is |
dt
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #63176.
/cc @cockroachdb/release
Previously, cluster backups taken with revision_history would not
include a database descriptor if it was dropped at the time of the
backup. This patch ensures that these database descriptors are picked up
by the backup and can therefore be restored with an AOST restore.
This bug appeared because backup incorrectly assumed that dropped
descriptors remained in the DROP state until their GC TTL. This is not
the case for database descriptors which are immediately deleted.
Release note (bug fix): Previously revision_history cluster backups
would not include dropped databases. This means that dropped databases
could not be restored from backups that were taken after the database
was dropped.