release-20.2: security: allow colons in cert-principal-map principals #67811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #67703 on behalf of @bobvawter.
/cc @cockroachdb/release
Customers whose internal certificate authority issues certificates with colons
in the principal name were unable to use the cert-principal-map flag.
This change makes the flag-parsing logic split each mapping on the last colon
in the mapping. This does not change the interpretation of existing uses of the
flag, but allows principal names with colons to be used without any need for
escape sequences.
Fixes #66435
Release note (cli change): The cert-principal-map flag now allows the
certificate principal name to contain colons.
Release justification: low risk, high benefit changes to existing functionality