Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup: mark some settings public #71962

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Conversation

dt
Copy link
Member

@dt dt commented Oct 25, 2021

This marks some of BACKUP's cluster settings as public as they are
intended for user-tuning to match their desired workload / requirements,
such as the delay before invoking priority reads or the target file size.

Release note (ops change): Some existing settings related to BACKUP execution are now listed by SHOW CLUSTER SETTINGS.

Fixes #71786.

@dt dt requested review from kathancox, a team and adityamaru and removed request for a team October 25, 2021 21:23
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@kathancox kathancox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David!

This marks some of BACKUP's cluster settings as public as they are
intended for user-tuning to match their desired workload / requirements,
such as the delay before invoking priority reads or the target file size.

Release note (ops change): Some existing settings related to BACKUP execution are now listed  by SHOW CLUSTER SETTINGS.
@dt
Copy link
Member Author

dt commented Oct 26, 2021

TFTRs!

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 26, 2021

Build succeeded:

@craig craig bot merged commit fa26501 into cockroachdb:master Oct 26, 2021
@dt dt deleted the backup-public-settings branch October 26, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change bulkio.backup.file_size cluster setting to public
4 participants