Fix the build on FreeBSD. #7376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. you'll also need to update the |
|
Thanks for the hint. Done. |
| @@ -19,6 +19,7 @@ | |||
| package status | |||
|
|
|||
| // #cgo darwin CPPFLAGS: -I../../../c-jemalloc/darwin_includes/internal/include | |||
| // #cgo freebsd CPPFLAGS: -I../../../c-jemalloc/freebsd_includes/internal/include | |||
There was a problem hiding this comment.
this ordering upsets my OCD
There was a problem hiding this comment.
I don't get it: "f" comes after "d" and before "l" in the alphabet, doesn't it?
There was a problem hiding this comment.
and yet this is not the order you used anywhere else
There was a problem hiding this comment.
This is mildly frustrating: if you wanted to communicate that the two files did not use the same ordering, why didn't you write so in the first place? It would have saved us two backs-and-forth. Anyway, it's corrected now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This together with cockroachdb/c-jemalloc#5 and elastic/gosigar#33 produces a working cockroach binary on FreeBSD 10.3-STABLE.
This change is