release-21.2: sql,server: create toString to role option #75494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #75271.
/cc @cockroachdb/release
Previously, the code was using roleOption.String() to
create a string to be used on queries. This was causing
an issue with roles that contained spaces within it,
e.g. role option
VALIDUNTIL
was being translate toVALIDUNTIL
instead of the correct wayVALID UNTIL
.This commit updates the String() function to correctly
add the space on the
VALID UNTIL
case.Release note (bug fix): Update the String() function of
roleOption to add a space on the role
VALID UNTIL
.Release Justification: Category 2, bug fix