Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: kv: Limit concurrency of catchup scans. #77866

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 15, 2022

Backport 1/1 commits from #77725 on behalf of @miretskiy.

/cc @cockroachdb/release


Limit concurrency of the catchup scans.
Prior to this change, distsender would issue all of the rangefeed
calls immediately, and the the KV server deal with limiting
the number of concurrent catchup scans it can handle. This has
a potential of using up entirety of the KV server budget by a single
rangefeed client (e.g. changefeed), thus starving all other users.

This PR adds a kv.rangefeed.catchup_scan_concurrency setting
to limit the number of catchup scans started by rangefeed client.

Fixes #77690

Release Notes (enterprise): Limit the number of concurent catchup scan
requests issued by rangefeed client.

Release Justification: Important stability and scalability improvement
to prevent a single rangefeed client from consuming entirety of catchup
scan iterator budget on a KV server.


Release justification:

Limit concurrency of the catchup scans.
Prior to this change, distsender would issue all of the rangefeed
calls immediately, and the the KV server deal with limiting
the number of concurrent catchup scans it can handle.  This has
a potential of using up entirety of the KV server budget by a single
rangefeed client (e.g. changefeed), thus starving all other users.

This PR adds a `kv.rangefeed.catchup_scan_concurrency` setting
to limit the number of catchup scans started by rangefeed client.

Release Notes (enterprise): Limit the number of concurent catchup scan
requests issued by rangefeed client.

Release Justfication: Important stability and scalability improvement
to prevent a single rangefeed client from consuming entirety of catchup
scan iterator budget on a KV server.
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 15, 2022 23:35
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-77725 branch from bb0f35b to 6899670 Compare March 15, 2022 23:35
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 15, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 15, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@miretskiy miretskiy merged commit 4ac2e43 into release-22.1 Mar 16, 2022
@miretskiy miretskiy deleted the blathers/backport-release-22.1-77725 branch March 16, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants