release-22.1: kv: Limit concurrency of catchup scans. #77866
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #77725 on behalf of @miretskiy.
/cc @cockroachdb/release
Limit concurrency of the catchup scans.
Prior to this change, distsender would issue all of the rangefeed
calls immediately, and the the KV server deal with limiting
the number of concurrent catchup scans it can handle. This has
a potential of using up entirety of the KV server budget by a single
rangefeed client (e.g. changefeed), thus starving all other users.
This PR adds a
kv.rangefeed.catchup_scan_concurrency
settingto limit the number of catchup scans started by rangefeed client.
Fixes #77690
Release Notes (enterprise): Limit the number of concurent catchup scan
requests issued by rangefeed client.
Release Justification: Important stability and scalability improvement
to prevent a single rangefeed client from consuming entirety of catchup
scan iterator budget on a KV server.
Release justification: