Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server, sql: add plan gist to active queries #88770

Merged
merged 1 commit into from Sep 29, 2022

Conversation

xinhaoz
Copy link
Member

@xinhaoz xinhaoz commented Sep 26, 2022

Closes #76554

This commit surfaces an executing query's plan gist. This information is added to the ListSessions response and the crdb_internal.{node,cluster}_queries tables. This field is only populated when the query enters the EXECUTING phase.

Release note (sql change): new column plan_gist
added to crdb_internal.{node,cluster}_queries
representing the compressed logical plan.

@xinhaoz xinhaoz requested a review from a team September 26, 2022 21:12
@xinhaoz xinhaoz requested review from a team as code owners September 26, 2022 21:12
@xinhaoz xinhaoz requested a review from a team September 26, 2022 21:12
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dhartunian dhartunian removed the request for review from a team September 27, 2022 14:59
Closes cockroachdb#76554

This commit surfaces an executing query's plan gist.
This information is added to the ListSessions response
and the `crdb_internal.{node,cluster}_queries` tables.
This field is only populated when the query enters the
EXECUTING phase.

Release note (sql change): new column `plan_gist`
added to `crdb_internal.{node,cluster}_queries`
representing the compressed logical plan.
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)

@xinhaoz
Copy link
Member Author

xinhaoz commented Sep 29, 2022

TFTR!
bors r+

@craig
Copy link
Contributor

craig bot commented Sep 29, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-22.2.x Flags PRs that need to be backported to 22.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the plan gist to crdb_internal.cluster_queries
3 participants