release-22.2: server, sql, ui: add plan gist to active queries, add explain plan to active stms and insights #90557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes cockroachdb#76554 This commit surfaces an executing query's plan gist. This information is added to the ListSessions response and the `crdb_internal.{node,cluster}_queries` tables. This field is only populated when the query enters the EXECUTING phase. Release note (sql change): new column `plan_gist` added to `crdb_internal.{node,cluster}_queries` representing the compressed logical plan.
Closes cockroachdb#79128 This commit splits the active statment details page into 2 tab views: 1. Overview - the active stmt details information that was already being displayed prior to this commit 2. Explain Tab - newly added as of this commit. The explain plan for this active statement. The explain plan for the active statement being viewed will be retrieved when the tab is clicked by making a req to decode the plan gist of the stmt. The explain tab is currently disabled for tenants until the sql http api is available. Release note (ui change): new tabs in active statement details page: 1. Overview - (previous page info of stmt details) 2. Explain Plan - the explain plan of the stmt, available if the returned plan gist is non-empty
This commit refactors the statement insight details page component from a class component to a functional component. Release note: None
Closes cockroachdb#88093 This commit adds a new tab to the statement insight details page. The page is now separated into two tabs: 1. Overview - what was already on the page (insights details) 2. Explain Plan - the explain plan for the stmt being viewed Release note (ui change): new tab view added to the stmt insight details page: 1. Overview - what was already on the page (insights details) 2. Explain Plan - the explain plan for the stmt being viewed
|
This change is |
xinhaoz
changed the title
maryliag
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, 6 of 6 files at r2, 1 of 1 files at r3, 7 of 7 files at r4, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ericharmeling)
This was referenced Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport:
Please see individual PRs for details.
Release justification: low-risk, high benefit change to existing functionality
/cc @cockroachdb/release