Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: ui: fix contention time tooltip on insights page #89125

Merged
merged 1 commit into from
Oct 4, 2022
Merged

release-22.2: ui: fix contention time tooltip on insights page #89125

merged 1 commit into from
Oct 4, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 30, 2022

Backport 1/1 commits from #89035 on behalf of @ericharmeling.

/cc @cockroachdb/release

This commit updates the High Contention Time tooltip on the insights page to accurately reflect the event's contention duration.

https://cockroachlabs.slack.com/archives/G01Q9D01NTU/p1664477246961729?thread_ts=1664473625.621409&cid=G01Q9D01NTU

https://www.loom.com/share/a8ce63ece586468e870d67118c0d8d5a

Release note: None

Release justification: bug fix

Release justification:

@ericharmeling
ui: fix contention time tooltip on insights page
1fc22f4 
This commit updates the High Contention Time description
on the insights page to accurately reflect the event's
contention duration.

Release note (ui change): The High Contention Time insight description now
accurately reflects the event's contention duration in the DB Console.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-89035 branch from eb51b10 to 1fc22f4 Compare September 30, 2022 22:12
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 30, 2022
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 30, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

THardy98
THardy98 approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@THardy98 THardy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ericharmeling and @maryliag)

@ericharmeling ericharmeling merged commit ea48952 into release-22.2 Oct 4, 2022
@ericharmeling ericharmeling deleted the blathers/backport-release-22.2-89035 branch October 4, 2022 19:59
@cockroach-teamcity cockroach-teamcity mentioned this pull request Oct 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@THardy98 THardy98 THardy98 approved these changes

@ericharmeling ericharmeling Awaiting requested review from ericharmeling

@maryliag maryliag Awaiting requested review from maryliag

Assignees

@ericharmeling ericharmeling

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @THardy98 @ericharmeling