kvserver: flush WAL on writing storage checkpoints #89369
Conversation
|
This change is |
There was a problem hiding this comment.
Release note (bug fix): flush WAL on writing storage checkpoints, which makes them correctly represent the state of storage when an inconsistency occurs
This can sound a lot more dramatic than it really is, since users don't know what a storage checkpoint is or when they occur. We should be extra clear here that this is only relevant for consistency checker failures, and does not affect database durability guarantees at all. Add e.g. "flush WAL when writing storage checkpoints on consistency checker failures".
pav-kv
force-pushed
the
checkpoint_flush_wal
branch
from
60253cc
to
e8a5d7f
Compare
|
Addressed comments. |
If a consistency check fails, it saves checkpoints on all replicas, to help with further investigation. Flushing WAL was disabled, so some checkpoints could be slightly out of date. This commit fixes that. Release justification: important bug fix Release note (bug fix): flush WAL when writing storage checkpoints on consistency checker failures
pav-kv
force-pushed
the
checkpoint_flush_wal
branch
from
e8a5d7f
to
669b872
Compare
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @erikgrinaker and @pavelkalinnikov)
|
bors r=erikgrinaker,sumeerbhola |
|
Build succeeded: |
If a consistency check fails, it saves checkpoints on all replicas, to help with further investigation. Flushing WAL was disabled, so some checkpoints could be slightly out of date. This commit fixes that.
Fixes #89287
Release justification: important bug fix
Release note (bug fix): flush WAL when writing storage checkpoints on consistency checker failures