Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eval: fix internal error casting bytes to bit #96002

Merged
merged 1 commit into from Jan 27, 2023
Merged

Conversation

msirek
Copy link
Contributor

@msirek msirek commented Jan 26, 2023

Fixes #95543

Release note (bug fix): This patch fixes an internal error which may occur in the SHOW RANGE FROM TABLE statement when the FOR ROW clause specifies a BYTE literal and the corresponding column data type is BIT.

@msirek msirek requested review from ajwerner, a team and DrewKimball January 26, 2023 15:39
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)

Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Copy link
Contributor Author

@msirek msirek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTRs!
bors r+

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)

@msirek
Copy link
Contributor Author

msirek commented Jan 26, 2023

bors r-

Fixes cockroachdb#95543

Release note (bug fix): This patch fixes an internal error which may
occur in the SHOW RANGE FROM TABLE statement when the FOR ROW clause
specifies a BYTE literal and the corresponding column data type is BIT.
@msirek msirek added the backport-22.2.x Flags PRs that need to be backported to 22.2. label Jan 27, 2023
@msirek
Copy link
Contributor Author

msirek commented Jan 27, 2023

bors r+

@craig craig bot merged commit b23943c into cockroachdb:master Jan 27, 2023
@craig
Copy link
Contributor

craig bot commented Jan 27, 2023

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Jan 27, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from c335a4e to blathers/backport-release-22.2-96002: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-22.2.x Flags PRs that need to be backported to 22.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: panic when interacting with BIT array
4 participants