Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: eval: fix internal error casting bytes to bit #96106

Merged
merged 1 commit into from Jan 30, 2023
Merged

release-22.2: eval: fix internal error casting bytes to bit #96106

merged 1 commit into from Jan 30, 2023

Conversation

msirek
Copy link
Contributor

@msirek msirek commented Jan 27, 2023

Backport 1/1 commits from #96002.

/cc @cockroachdb/release

Fixes #95543

Release note (bug fix): This patch fixes an internal error which may occur in the SHOW RANGE FROM TABLE statement when the FOR ROW clause specifies a BYTE literal and the corresponding column data type is BIT.

Release justification: Very low risk fix for internal error casting bytes to bit

@msirek msirek requested review from mgartner, ajwerner and a team January 27, 2023 18:12
@blathers-crl
Copy link

blathers-crl bot commented Jan 27, 2023 •
edited by msirek

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

eval: fix internal error casting bytes to bit
de8a3c7 
Fixes cockroachdb#95543

Release note (bug fix): This patch fixes an internal error which may
occur in the SHOW RANGE FROM TABLE statement when the FOR ROW clause
specifies a BYTE literal and the corresponding column data type is BIT.
@msirek
Copy link
Contributor Author

msirek commented Jan 30, 2023

This support issue is hitting this bug:
https://github.com/cockroachlabs/support/issues/2041

@msirek msirek merged commit 999fbe4 into cockroachdb:release-22.2 Jan 30, 2023
@msirek msirek deleted the backport22.2-96002 branch January 30, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgartner mgartner mgartner approved these changes

@ajwerner ajwerner Awaiting requested review from ajwerner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@msirek @cockroach-teamcity @mgartner