Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: sql: add metrics for prepared statement memory usage #97654

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Feb 24, 2023

Backport 1/1 commits from #97590 on behalf of @michae2.

/cc @cockroachdb/release


Add node-level metrics for memory used by prepared statements across all sessions.

Assists: #72581

Epic: None

Release note (ui change): Add the following new metrics to track memory usage of prepared statements in sessions:

  • sql.mem.internal.session.prepared.current
  • sql.mem.internal.session.prepared.max-avg
  • sql.mem.internal.session.prepared.max-count
  • sql.mem.internal.session.prepared.max-max
  • sql.mem.internal.session.prepared.max-p50
  • sql.mem.internal.session.prepared.max-p75
  • sql.mem.internal.session.prepared.max-p90
  • sql.mem.internal.session.prepared.max-p99
  • sql.mem.internal.session.prepared.max-p99.9
  • sql.mem.internal.session.prepared.max-p99.99
  • sql.mem.internal.session.prepared.max-p99.999
  • sql.mem.sql.session.prepared.current
  • sql.mem.sql.session.prepared.max-avg
  • sql.mem.sql.session.prepared.max-count
  • sql.mem.sql.session.prepared.max-max
  • sql.mem.sql.session.prepared.max-p50
  • sql.mem.sql.session.prepared.max-p75
  • sql.mem.sql.session.prepared.max-p90
  • sql.mem.sql.session.prepared.max-p99
  • sql.mem.sql.session.prepared.max-p99.9
  • sql.mem.sql.session.prepared.max-p99.99
  • sql.mem.sql.session.prepared.max-p99.999

Release justification: small change to metrics to improve observability.

Add node-level metrics for memory used by prepared statements across all
sessions.

Assists: #72581

Epic: None

Release note (ui change): Add the following new metrics to track memory
usage of prepared statements in sessions:
- sql.mem.internal.session.prepared.current
- sql.mem.internal.session.prepared.max-avg
- sql.mem.internal.session.prepared.max-count
- sql.mem.internal.session.prepared.max-max
- sql.mem.internal.session.prepared.max-p50
- sql.mem.internal.session.prepared.max-p75
- sql.mem.internal.session.prepared.max-p90
- sql.mem.internal.session.prepared.max-p99
- sql.mem.internal.session.prepared.max-p99.9
- sql.mem.internal.session.prepared.max-p99.99
- sql.mem.internal.session.prepared.max-p99.999
- sql.mem.sql.session.prepared.current
- sql.mem.sql.session.prepared.max-avg
- sql.mem.sql.session.prepared.max-count
- sql.mem.sql.session.prepared.max-max
- sql.mem.sql.session.prepared.max-p50
- sql.mem.sql.session.prepared.max-p75
- sql.mem.sql.session.prepared.max-p90
- sql.mem.sql.session.prepared.max-p99
- sql.mem.sql.session.prepared.max-p99.9
- sql.mem.sql.session.prepared.max-p99.99
- sql.mem.sql.session.prepared.max-p99.999
@blathers-crl blathers-crl bot requested a review from a team February 24, 2023 21:11
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-97590 branch from 85fba6a to d3e9af3 Compare February 24, 2023 21:11
@blathers-crl
Copy link
Author

blathers-crl bot commented Feb 24, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl
Copy link
Author

blathers-crl bot commented Feb 24, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Feb 24, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rharding6373 rharding6373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball, @michae2, and @yuzefovich)

@michae2 michae2 merged commit 897001b into release-22.2 Feb 27, 2023
@michae2 michae2 deleted the blathers/backport-release-22.2-97590 branch February 27, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants