Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: server,sql: remove usages of prettify on details pages #99453

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Mar 24, 2023

Backport 1/1 commits from #99450.

/cc @cockroachdb/release


The usage of prettify_statement and Pretty could cause OOM. Those were being used on statemen details and transaction insight details.
This commit removes those usages and add a very basic formatting function that can be used on the SQLBox component.

Part Of #91197

Release note (performance improvement): Removal of prettify usages that could cause OOM on Statement Details and Transaction Details page.


Release justification: bug fix

@maryliag maryliag requested review from a team March 24, 2023 03:43
@blathers-crl
Copy link

blathers-crl bot commented Mar 24, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag force-pushed the backport22.2-99450 branch 3 times, most recently from 0d1fb50 to 3b822e5 Compare March 24, 2023 05:03
Copy link
Contributor

@j82w j82w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

The usage of `prettify_statement` and `Pretty` could cause
OOM. Those were being used on statemen details and
transaction insight details.
This commit removes those usages and add a very basic
formatting function that can be used on the SQLBox
component.

Part Of cockroachdb#91197

Release note (performance improvement): Removal of prettify
usages that could cause OOM on Statement Details and
Transaction Details page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants