Update the install dependency list #2893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jseldess
approved these changes
Apr 10, 2018
There was a problem hiding this comment.
LGTM.
Question, though: Why do you think this change didn't make it into the rc release notes? Also, I don't see how I could've intuited this doc update from the commit text. Do you think the release note text could have been written to make this clearer?
|
This doc change is unrelated to the changes in CockroachDB. We have a PR accepted for 2.0.1 which will require this doc change to be published, but we could already publish this doc change even if the code PR didn't exist. |
|
OK. Thanks for the clarification, @knz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflects cockroachdb/cockroach#24513
Reflects cockroachdb/cockroach#24531
Informs cockroachdb/cockroach#24625 (comment)