cli: bump the libedit dep and fix linking isues #24513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I am in the process of updating the builder image. Will update the PR when that completes. |
|
Review status: 0 of 3 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
a-robinson
approved these changes
Apr 5, 2018
|
I need to complete the builder image before I complete the coreos testing. Builder image still building. It takes a while. |
Prior to this patch, the underlying `go-libedit` dependency would set LDFLAGS to link on linux against libtinfo, mistakenly assuming that this would cause the resulting Go binary to only use the subset of whatever tinfo implementation on linux system dedicated to terminal access. The mistake is that there is no such thing -- there is no standad standalone libtinfo on linux, and on most linux system it is either a symlink to libncurses, or doesn't exist at all! This patch corrects the issue by upgrading to the newest go-libedit code which links against libncurses instead, which is guaranteed to exist (it's been part of the Linux Standard Base forever). The builder docker image is upgraded accordingly. Release note (general change): Prevent execution errors reporting a missing `libtinfo.so.5` on linux systems.
|
Updated builder image. Will iterate until CI is green then test coreos. |
It works all right on coreos -- was able to start server, client, use in docker etc. |
|
bors r+ |
craig bot
added a commit
that referenced
this pull request
Apr 5, 2018
24513: cli: bump the libedit dep and fix linking isues r=knz a=knz Prior to this patch, the underlying `go-libedit` dependency would set LDFLAGS to link on linux against libtinfo, mistakenly assuming that this would cause the resulting Go binary to only use the subset of whatever tinfo implementation on linux system dedicated to terminal access. The mistake is that there is no such thing -- there is no standad standalone libtinfo on linux, and on most linux system it is either a symlink to libncurses, or doesn't exist at all! This patch corrects the issue by upgrading to the newest go-libedit code which links against libncurses instead, which is guaranteed to exist (it's been part of the Linux Standard Base forever). The builder docker image is upgraded accordingly. Release note (general change): Prevent execution errors reporting a missing `libtinfo.so.5` on linux systems. Fixes #24492.
Build succeeded |
craig bot
added a commit
that referenced
this pull request
Apr 5, 2018
24531: cherry-pick 2.0: cli: bump the libedit dep and fix linking issues r=knz a=knz Picks #24513. cc @cockroachdb/release
This was referenced Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, the underlying
go-libeditdependency would setLDFLAGS to link on linux against libtinfo, mistakenly assuming that
this would cause the resulting Go binary to only use the subset of
whatever tinfo implementation on linux system dedicated to terminal
access.
The mistake is that there is no such thing -- there is no standad
standalone libtinfo on linux, and on most linux system it is either
a symlink to libncurses, or doesn't exist at all!
This patch corrects the issue by upgrading to the newest go-libedit
code which links against libncurses instead, which is guaranteed to
exist (it's been part of the Linux Standard Base forever).
The builder docker image is upgraded accordingly.
Release note (general change): Prevent execution errors reporting a
missing
libtinfo.so.5on linux systems.Fixes #24492.