-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: bump the libedit dep and fix linking isues #24513
Conversation
I am in the process of updating the builder image. Will update the PR when that completes. |
Review status: 0 of 3 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @knz! I assume you verified this works on coreos?
I need to complete the builder image before I complete the coreos testing. Builder image still building. It takes a while. |
Prior to this patch, the underlying `go-libedit` dependency would set LDFLAGS to link on linux against libtinfo, mistakenly assuming that this would cause the resulting Go binary to only use the subset of whatever tinfo implementation on linux system dedicated to terminal access. The mistake is that there is no such thing -- there is no standad standalone libtinfo on linux, and on most linux system it is either a symlink to libncurses, or doesn't exist at all! This patch corrects the issue by upgrading to the newest go-libedit code which links against libncurses instead, which is guaranteed to exist (it's been part of the Linux Standard Base forever). The builder docker image is upgraded accordingly. Release note (general change): Prevent execution errors reporting a missing `libtinfo.so.5` on linux systems.
Updated builder image. Will iterate until CI is green then test coreos. |
It works all right on coreos -- was able to start server, client, use in docker etc. |
bors r+ |
24513: cli: bump the libedit dep and fix linking isues r=knz a=knz Prior to this patch, the underlying `go-libedit` dependency would set LDFLAGS to link on linux against libtinfo, mistakenly assuming that this would cause the resulting Go binary to only use the subset of whatever tinfo implementation on linux system dedicated to terminal access. The mistake is that there is no such thing -- there is no standad standalone libtinfo on linux, and on most linux system it is either a symlink to libncurses, or doesn't exist at all! This patch corrects the issue by upgrading to the newest go-libedit code which links against libncurses instead, which is guaranteed to exist (it's been part of the Linux Standard Base forever). The builder docker image is upgraded accordingly. Release note (general change): Prevent execution errors reporting a missing `libtinfo.so.5` on linux systems. Fixes #24492.
Build succeeded |
24531: cherry-pick 2.0: cli: bump the libedit dep and fix linking issues r=knz a=knz Picks #24513. cc @cockroachdb/release
Prior to this patch, the underlying
go-libedit
dependency would setLDFLAGS to link on linux against libtinfo, mistakenly assuming that
this would cause the resulting Go binary to only use the subset of
whatever tinfo implementation on linux system dedicated to terminal
access.
The mistake is that there is no such thing -- there is no standad
standalone libtinfo on linux, and on most linux system it is either
a symlink to libncurses, or doesn't exist at all!
This patch corrects the issue by upgrading to the newest go-libedit
code which links against libncurses instead, which is guaranteed to
exist (it's been part of the Linux Standard Base forever).
The builder docker image is upgraded accordingly.
Release note (general change): Prevent execution errors reporting a
missing
libtinfo.so.5
on linux systems.Fixes #24492.