Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support https endpoint #18

Closed
glennfawcett opened this issue Apr 19, 2020 · 2 comments · Fixed by #73
Closed

Support https endpoint #18

glennfawcett opened this issue Apr 19, 2020 · 2 comments · Fixed by #73
Assignees
@BramGruneir

Comments

@glennfawcett
Copy link
Contributor

Did the following on the source:

CREATE CHANGEFEED FOR TABLE me INTO 'experimental-https://172.31.2.194:26258/me.sql' WITH resolved, updated;

The log from the source machine showed:

error: retryable changefeed error: retryable http error: Put https://172.31.2.194:26258/me.sql/2020-04-19/202004191704475286656650000000001-bcfd19dba28ea94a-3-5017-00000000-me-1.ndjson: http: server gave HTTP response to HTTPS client
@BramGruneir BramGruneir self-assigned this Apr 19, 2020
@bobvawter bobvawter changed the title https changefeed not working Support https endpoint Dec 15, 2021
@bobvawter
Copy link
Member

Work in #73 will make it easier to add a TLS configuration to the http server. Can also dig up code to have the cdc-sink server generate a self-signed certificate for testing purposes.

@bobvawter
Copy link
Member

Needed to implement this in #73 to support v21.2's webhook-https:// scheme.

@bobvawter bobvawter linked a pull request Dec 16, 2021 that will close this issue
cdc-sink: Overhaul #73
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BramGruneir BramGruneir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cdc-sink: Overhaul cockroachdb/replicator
3 participants
@bobvawter @BramGruneir @glennfawcett