Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot enter the hash character # #89

Open
lucatrv opened this issue Feb 29, 2024 · 2 comments · May be fixed by #95
Open

Cannot enter the hash character # #89

lucatrv opened this issue Feb 29, 2024 · 2 comments · May be fixed by #95
Labels
bug Something isn't working

Comments

@lucatrv
Copy link
Contributor

lucatrv commented Feb 29, 2024

Describe the bug
The hash character # cannot be entered.

To Reproduce
Run koji and try to enter the hash character #, either directly by typing or by copy/paste.

Additional context
I'm on Windows 10, I tried both with Git Bash and Powershell.

@lucatrv lucatrv added the bug Something isn't working label Feb 29, 2024
@cococonscious
Copy link
Owner

While I couldn't reproduce the bug on my Windows machine, could you please try again with the main branch head (cargo install --git https://github.com/cococonscious/koji) and see if it's working now? Maybe the new prompt library handles it differently...

@lucatrv
Copy link
Contributor Author

lucatrv commented Oct 15, 2024

I confirm that the issue is still present in the current released version 2.2.0, but it is not present in the main branch head. So apparently the issue has already been fixed with some recent commit yet to be released.

@cococonscious cococonscious linked a pull request Oct 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants