Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Skeleton's opacity can not work normally #17497

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

bofeng-song
Copy link
Contributor

@bofeng-song bofeng-song commented Aug 6, 2024

Re: #
#16960
#16601

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Greptile Summary

This PR addresses issues with Skeleton opacity in the Cocos Engine, implementing changes to ensure proper opacity handling across different rendering modes.

  • Modified cocos/spine/assembler/simple.ts to use a more precise EPSILON comparison for opacity calculations
  • Updated cocos/spine/skeleton.ts to include node opacity in alpha value calculations for the _updateColor method
  • Adjusted SkeletonCacheAnimation::render in native C++ code to incorporate entity opacity in final color calculations
  • Modified SkeletonRenderer::render in native C++ code to include entity opacity in the opacity calculation

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings

cocos/spine/assembler/simple.ts Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Aug 6, 2024

Interface Check Report

This pull request does not change any public interfaces !

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings

cocos/spine/assembler/simple.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants