Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the tween test case #3908

Merged
merged 3 commits into from Feb 27, 2019
Merged

add the tween test case #3908

merged 3 commits into from Feb 27, 2019

Conversation

ColinCollins
Copy link
Contributor

@ColinCollins ColinCollins commented Feb 25, 2019

Re: https://github.com/cocos-creator/2d-tasks/issues/1105

  1. 增加了 tween action 的本地测试用例
  2. 调整 test 内关于 resetGame 中关于 schedule 的调用。。。。
    具体调整是因为:
    resetGame 会清除当前的 schedule 所以需要 reset 重新声明所有 schedule
    image

}
}
var tmpTween = tween()
.to(0.5, { scale: 2 })
Copy link
Contributor

@2youyou2 2youyou2 Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些都用一个缩进吧,这么多缩进太难看

cc.game.resume();
// builtin easing
var node = initNode('easeNode');
tween(node).to(0.1, { scale: 2 }, { easing: 'sineOutIn' })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easing 的 test 应该测试 easing 有没有作用,可以手动调用 action 的 update 来测试

var action =tween(node).to(0.1, { scale: 2 }, { easing: 'sineOutIn' });
action.update(time);

return start + (end - start) * t;
}
})
.call(function () { strictEqual(node.scale, 2, 'tween can set progress property'); })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同 easing 的测试一样,应该测试过程值

});

asyncTest('progress test', function () {
cc.game.resume();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缩进不一致

var position = tween().to(0.5, { position: cc.v2(100, 100) });

var node = initNode('reuseNode');
tween(node).then(scale).then(angle).then(position)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这缩进太难看了吧。。

1. keep all chain method start at the char 'n' below
@pandamicro pandamicro merged commit b3dfa7b into cocos:v2.0-release Feb 27, 2019
@2youyou2
Copy link
Contributor

2youyou2 commented Mar 4, 2019

pandamicro pushed a commit that referenced this pull request Mar 11, 2019
* Add RenderMode TS support (#3879)

Add spine assembler var define

* fix unit test for sprite (#3870)

* Fix 1.x to 2.x particle custom data is invalid bug (#3885)

* Improve particle definition data code (#3892)

* fix event failed to reorder after modifying zIndex for 2d-tasks/issues/1130 (#3895)

* Move BlendFunctionFactors to Sprite and ParticleSystem only (#3900)

* change API:loadSubpackage to load index.js (#3899)

* mark component.enabled as animatable (#3898)

* ban JIT support on baidugame (#3903)

* Fix dragonbones multiple texture bug (#3897)

* Fix dragonbones change cloth bug

* Adapt to old api-> on off once

* DragonBonesAsset do not store dragonBones data

* fix some error

* fix web spine debug draw color error

* Set limit time to 30s

* fix label rendering in open data context (#3911)

* fix: shaders have same uniform name, different type will effect wrong (#3876)

* fix: shaders have same uniform name, different type will effect wrong

* fix shaders have same uniform name, different type will effect wrong

* fix shaders have same uniform name, different type will effect wrong, refine

* add deprecated property in EditBox in v2.0 (#3912)

* Fix dragonbones exception (#3914)

* revert particles system attribute definition (#3919)

* fix emit target scale changed events twice (#3922)

* add the tween test case (#3908)

* add the tween test case

* modify the format of the test-tween.js

1. keep all chain method start at the char 'n' below

* fixed the tween bugs

* Fix spine premultipliedAlpha serialize bug (#3924)

* cancel disable dynamic atlas on chrome. (#3929)

* Add cache mode of label. (#3916)

* Add cache mode of label.

* fix revised comments of pr.

* Simplified variable name.

* share canvas pool.

* cancel use node color.

* modify comment and reserve _batchAsBitMap.

* optimize the assignment of color and delete blendFactor.

* delete reserveImage.

* modify to center alignment.

* modify letter-font do not use node color.

* add outline support of letter-font

* add letter atlas reset on editor when scene loaded.

* change LETTER to CHAR

* modify comment

* Wechat -> WeChat

* Add spine render mode chinese tip (#3933)

* fix label rendering error on native (#3936)

* fix label rendering error on native

* fix rendering error on native

* revert first commit

* clear letter atlas when scene launch. (#3938)

*  reset the CHAR mode to NONE on subdomin. (#3940)

* reset the CHAR mode to NONE on subdomin.

* reset CHAR mode on subdomin

* set rigidbody awake visible is false (#3941)

* fix canvasPool error on subdomin (#3942)

* update rigidbody awake tips and add awakeOnLoad (#3944)

* fix label error when font change on editor. (#3946)

* Rename skeleton RenderMode to AnimationCacheMode (#3947)

* Rename skeleton RenderMode to AnimationCacheMode

* Rename skeleton RenderMode to AnimationCacheMode

* fix label blur when using dark font color (#3949)

* optimize editBox style (#3952)

* To adapt the adjust of the webview impl in the jsb (#3697) (#3951)

* fix the problem of label that first modified is invalid. (#3959)

* Fix create ArmatureDisplay by code but no set asset, then invoke some api about event, will throw error (#3966)

* fix get auido state bug (#3974)

* small fixed

* small fixed
minggo pushed a commit that referenced this pull request Feb 10, 2022
* misc fixes

* remove resizable flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants