Fix UIText issue and Label getContentSize value wrong in retina mode #3306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @ntrrgc the issue with label under retina display have been fixed, please take a look |
| node._strokeShadowOffsetX = locStrokeShadowOffsetX; | ||
| node._strokeShadowOffsetY = locStrokeShadowOffsetY; | ||
|
|
||
| // need computing _anchorPointInPoints | ||
| var locAP = node._anchorPoint; | ||
| this._anchorPointInPoints.x = (locStrokeShadowOffsetX * 0.5) + ((locSize.width - locStrokeShadowOffsetX) * locAP.x); | ||
| this._anchorPointInPoints.y = (locStrokeShadowOffsetY * 0.5) + ((locSize.height - locStrokeShadowOffsetY) * locAP.y); | ||
| this._anchorPointInPoints.y = (locStrokeShadowOffsetY * 0.5) + ((locSize.width - locStrokeShadowOffsetY) * locAP.y); |
There was a problem hiding this comment.
Why have you substituted height for width here?
|
How is it supposed to work? |
ntrrgc
reviewed
Nov 9, 2016
| this._texRect.height = locSize.height; | ||
| } | ||
| var nodeW = locSize.width / pixelRatio, nodeH = locSize.height / pixelRatio; | ||
| node.setContentSize(nodeW, nodeH); |
There was a problem hiding this comment.
You are setting the design content size here...
| return true; | ||
| } | ||
| this._saveStatus(); | ||
| node.setTextureRect(cc.rect(0, 0, width, height)); | ||
| node.setTextureRect(this._texRect); |
There was a problem hiding this comment.
But it's being overwritten here. See the default implementation of setTextureRect() in CCSprite: https://github.com/cocos2d/cocos2d-html5/blob/develop/cocos2d/core/sprites/CCSprite.js#L738
|
I don't know if it's better or worse, but here is a simpler solution: #3407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #3294