Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To use some HTTP client library those use send(null) like `superage… #16989

Merged
merged 1 commit into from
Jan 5, 2017

Conversation

kosmosR2
Copy link
Contributor

To use some HTTP client library those use XMLHttpRequest.send(null) like superagent,XMLHTTPRequest should send a empty request instead of abort.

…nt`,`XMLHTTPRequest` should send a empty request instead of abort.
@minggo
Copy link
Contributor

minggo commented Dec 14, 2016

Sorry, what's the issue?

@kosmosR2
Copy link
Contributor Author

In JSB,when I use some HTTP libraries from npm like superagent and send a GET request without specify content,the default action of those libraries is calling XMLHttpRequest.send(null) which leads to abort the request in original code.

@leeyeh
Copy link

leeyeh commented Dec 20, 2016

Any progress here?

@minggo minggo added this to the 3.15 milestone Jan 5, 2017
@minggo minggo merged commit 44fb4ba into cocos2d:v3 Jan 5, 2017
stevetranby added a commit to stevetranby/cocos2d-x that referenced this pull request Jan 14, 2017
…futurePRs

* commit 'cb95ed5b1831eec4ef7bc6bc94bf51ea2f05bbd8':
  English refinements (cocos2d#17117)
  Allow velocity to be applied to Chipmunk's kinematic bodies (cocos2d#17094)
  To use some HTTP client library those use `send(null)` like `superagent`,`XMLHTTPRequest` should send a empty request instead of abort. (cocos2d#16989)
  [ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json automatically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants