https downloader timeout on win/mac #18935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is hard to refer to 404 page :(. |
drelaptop
reviewed
Jul 12, 2018
cocos/network/CCDownloader-curl.cpp
Outdated
| @@ -518,7 +521,7 @@ namespace cocos2d { namespace network { | |||
| timeout.tv_sec = timeoutMS / 1000; | |||
| timeout.tv_usec = (timeoutMS % 1000) * 1000; | |||
|
|
|||
| rc = select(maxfd+1, &fdread, &fdwrite, &fdexcep, &timeout); | |||
| rc = select(maxfd+1, &fdread, &fdwrite, &fdexcep, 50); | |||
There was a problem hiding this comment.
what's the meaning of number 50 ？
|
I think it's better to add some description to explain what happened and what solved. @PatriceJiang |
|
it is a similar PR as cocos/engine-native#1382 . @minggo |
huangwei1024
pushed a commit
to huangwei1024/cocos2d-x
that referenced
this pull request
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timeout error occurs when trying to download HTTPS content on windows.
the original polling
sleep(delay) time is too long and should be separated fromselecttimeout.