-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go on, Copy resources to "Resources/" on win32 #19166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are right js/lua *.vcxproj should be updated. Thank you! I think that we should keep the same folder structure for linux and win32. I have a plan to replace function cocos_copy_res with following implementation:
|
yeah, I can fix it in this PR.
|
@drelaptop thank you! |
stevetranby
added a commit
to stevetranby/cocos2d-x
that referenced
this pull request
Dec 3, 2018
* commit '387e1a77b5822475e5c499fa1e7539144b7aac30': update cocos cmd, disable "gen-libs" (cocos2d#19167) go on, Copy resources to "Resources/" on win32 (cocos2d#19166) [TiledMap] locate image path relative to tsx file (cocos2d#19147) # Conflicts: # cocos/editor-support/spine/proj.win32/libSpine.vcxproj # cocos/scripting/js-bindings/proj.win32/libjscocos2d.vcxproj # cocos/scripting/lua-bindings/proj.win32/libluacocos2d.vcxproj # templates/js-template-default/frameworks/runtime-src/proj.win32/HelloJavascript.sln # templates/js-template-default/frameworks/runtime-src/proj.win32/HelloJavascript.vcxproj # templates/lua-template-default/frameworks/runtime-src/proj.win32/HelloLua.sln # templates/lua-template-default/frameworks/runtime-src/proj.win32/HelloLua.vcxproj # tests/js-tests/project/proj.win32/js-tests.vcxproj # tests/lua-empty-test/project/proj.win32/lua-empty-test.vcxproj # tests/lua-tests/project/proj.win32/lua-tests.win32.vcxproj # tools/cocos2d-console
huangwei1024
pushed a commit
to huangwei1024/cocos2d-x
that referenced
this pull request
Jun 20, 2019
* re-target on wi10 for win32 project * fix js-tests sources copy * fix lua tests * fix js template * remove libbox2d.vcxproj ref * improve js source copy * copy source in post build event * little improve * update external
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve #19153
with
_defaultResRootPath
changed, you will have to adapt js/lua resources copy too, or you will get file not found error. so I don't think it's elegent to do this work "Copy resources to "Resources/" on win32".please give your options @crazyhappygame