fix ProgramState and Program performance #20189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minggo
reviewed
Oct 11, 2019
cocos/renderer/CCMaterial.cpp
Outdated
| pass->setProgramState(programState); | ||
|
|
||
| CC_SAFE_RELEASE(program); |
There was a problem hiding this comment.
Should release ProgramState too, as Pass::setProgramState will retain it.
minggo
reviewed
Oct 11, 2019
|
|
||
| auto program = backend::Device::getInstance()->newProgram(positionTextureColor_vert, fragSource.c_str()); | ||
| auto glprogram = new backend::ProgramState(program); | ||
| CC_SAFE_RELEASE(program); |
There was a problem hiding this comment.
May be need to do autorelease for program state as the method name is createXXX
minggo
reviewed
Oct 11, 2019
cocos/renderer/backend/Device.h
Outdated
| * @return A Program instance. | ||
| */ | ||
| virtual Program* createBuiltinProgram(ProgramType type); | ||
|
|
There was a problem hiding this comment.
Device do have to distinguish builtin or not. It just creates a program. Add Program::getBuiltinProgram() is a better idea.
minggo
approved these changes
Oct 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues discuss here