closed #2359: Sprite will become white block when using CCControlSwitch. #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rolSwitch. setShaderProgram should not be in Sprite::setTexture since setTexture is not related to shader.
dumganhar
pushed a commit
that referenced
this pull request
Jul 3, 2013
Sprite will become white block when using CCControlSwitch. setShaderProgram should not be in Sprite::setTexture since setTexture is not related to shader.
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
Sprite will become white block when using CCControlSwitch. setShaderProgram should not be in Sprite::setTexture since setTexture is not related to shader.
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 29, 2014
Sprite will become white block when using CCControlSwitch. setShaderProgram should not be in Sprite::setTexture since setTexture is not related to shader.
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
Sprite will become white block when using CCControlSwitch. setShaderProgram should not be in Sprite::setTexture since setTexture is not related to shader.
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
Sprite will become white block when using CCControlSwitch. setShaderProgram should not be in Sprite::setTexture since setTexture is not related to shader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setShaderProgram should not be in Sprite::setTexture since setTexture is not related to shader.
Developer has responsibility to reset shaderprogram when texture is changed from NULL to non-NULL or from non-NULL to NULL.