Added virtual destructors to some interfaces to fix issue 3095 #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumganhar
pushed a commit
that referenced
this pull request
Jul 26, 2013
Added virtual destructors to some interfaces to fix issue 3095
|
Merged, thanks. |
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
Added virtual destructors to some interfaces to fix issue 3095
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 29, 2014
Added virtual destructors to some interfaces to fix issue 3095
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
Added virtual destructors to some interfaces to fix issue 3095
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
Added virtual destructors to some interfaces to fix issue 3095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #3095 :
A subclass of connection_base3 is beign deleted through a pointer of this type, which doesn't have a virtual destructor and will cause a memory leak because no other destructors will be called!!!
You can see it in sigslot.h lines 760, 872, 916...
This happens with a lot of "interfaces" of sigslot. Every class that will be inherited MUST have virtual destructors because someone could delete a object of through a pointer to them and have a memory leak.