Take orientation into account when reporting accelerometer sensor readout #3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _orientation = AConfiguration_getOrientation(_currentconf); | ||
|
|
||
| cocos2d::Director* pDirector = cocos2d::Director::getInstance(); | ||
| if (ACONFIGURATION_ORIENTATION_LAND != _orientation) { |
There was a problem hiding this comment.
Please add { in a new line to obey the coding style.
And don't use Hungarian style: pDirector.
Thanks.
There was a problem hiding this comment.
Fixed the hungarian notation.
The coding style seems to be conflicted about braces see
http://www.cocos2d-x.org/projects/cocos2d-x/wiki/Cocos2d_C++_Coding_Style#Conditionals
vs.
http://www.cocos2d-x.org/projects/cocos2d-x/wiki/Cocos2d_C++_Coding_Style#Function-Declarations-and-Definitions
minggo
added a commit
that referenced
this pull request
Aug 10, 2013
Take orientation into account when reporting accelerometer sensor readout
boyu0
added a commit
to boyu0/cocos2d-x
that referenced
this pull request
Jan 6, 2014
boyu0
added a commit
to boyu0/cocos2d-x
that referenced
this pull request
Jan 6, 2014
boyu0
added a commit
to boyu0/cocos2d-x
that referenced
this pull request
Jan 7, 2014
boyu0
added a commit
to boyu0/cocos2d-x
that referenced
this pull request
Jan 7, 2014
dumganhar
pushed a commit
that referenced
this pull request
Jan 7, 2014
issue #3401: physical lua binding
boyu0
added a commit
to boyu0/cocos2d-x
that referenced
this pull request
Jan 15, 2014
…, and fix some bugs.
boyu0
added a commit
to boyu0/cocos2d-x
that referenced
this pull request
Jan 15, 2014
boyu0
added a commit
to boyu0/cocos2d-x
that referenced
this pull request
Jan 26, 2014
boyu0
pushed a commit
to boyu0/cocos2d-x
that referenced
this pull request
Jan 27, 2014
boyu0
pushed a commit
to boyu0/cocos2d-x
that referenced
this pull request
Jan 27, 2014
boyu0
pushed a commit
to boyu0/cocos2d-x
that referenced
this pull request
Jan 27, 2014
dumganhar
pushed a commit
that referenced
this pull request
Jan 27, 2014
issue #3401: add bit operation for lua physics test
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
Take orientation into account when reporting accelerometer sensor readout
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
issue cocos2d#3401: physical lua binding
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
…, and fix some bugs.
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
issue cocos2d#3401: add bit operation for lua physics test
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 29, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 29, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 29, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 29, 2014
issue cocos2d#3401: add bit operation for lua physics test
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
Take orientation into account when reporting accelerometer sensor readout
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
issue cocos2d#3401: physical lua binding
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
…, and fix some bugs.
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
issue cocos2d#3401: add bit operation for lua physics test
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
Take orientation into account when reporting accelerometer sensor readout
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
issue cocos2d#3401: physical lua binding
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
…, and fix some bugs.
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
issue cocos2d#3401: add bit operation for lua physics test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.