closed #4163: add cceditbox to winrt

[squirrelChen]

@stammen @dumganhar
please review it.

[stammen]

Sorry I have not got to this review yet. I am close to finishing cocos2d-x 3.0 for wp8-xaml. I will review this early next week.

Thanks,

Dale

From: Jingchen [mailto:notifications@github.com]
Sent: Friday, March 14, 2014 5:55 AM
To: cocos2d/cocos2d-x
Cc: Dale Stammen (MS OPEN TECH)
Subject: [cocos2d-x] closed #4163: add cceditbox to winrt (#5805)

@stammenhttps://github.com/stammen @dumganharhttps://github.com/dumganhar
please review it.

---

You can merge this Pull Request by running

git pull https://github.com/koowolf/cocos2d-x CCEditBox_winrt

Or view, comment on, or merge it at:

#5805

Commit Summary

• closed [AUTO] : updating submodule reference to latest autogenerated bindings #4163: add cceditbox to winrt

File Changes

• M cocos2dx/platform/winrt/CCEGLView.cpphttps://github.com/closed #4163: add cceditbox to winrt #5805/files#diff-0 (39)
• M cocos2dx/platform/winrt/CCEGLView.hhttps://github.com/closed #4163: add cceditbox to winrt #5805/files#diff-1 (14)
• A extensions/GUI/CCEditBox/CCEditBoxImplWinrt.cpphttps://github.com/closed #4163: add cceditbox to winrt #5805/files#diff-2 (325)
• A extensions/GUI/CCEditBox/CCEditBoxImplWinrt.hhttps://github.com/closed #4163: add cceditbox to winrt #5805/files#diff-3 (129)
• M extensions/proj.winrt/libExtensions.vcxprojhttps://github.com/closed #4163: add cceditbox to winrt #5805/files#diff-4 (5)
• M extensions/proj.winrt/libExtensions.vcxproj.filtershttps://github.com/closed #4163: add cceditbox to winrt #5805/files#diff-5 (18)
• M samples/Cpp/TestCpp/Classes/ExtensionsTest/ExtensionsTest.cpphttps://github.com/closed #4163: add cceditbox to winrt #5805/files#diff-6 (8)
• A samples/Cpp/TestCpp/proj.winrt/EditBox.xamlhttps://github.com/closed #4163: add cceditbox to winrt #5805/files#diff-7 (16)
• A samples/Cpp/TestCpp/proj.winrt/EditBox.xaml.cpphttps://github.com/closed #4163: add cceditbox to winrt #5805/files#diff-8 (210)
• A samples/Cpp/TestCpp/proj.winrt/EditBox.xaml.hhttps://github.com/closed #4163: add cceditbox to winrt #5805/files#diff-9 (62)
• M samples/Cpp/TestCpp/proj.winrt/MainPage.xaml.cpphttps://github.com/closed #4163: add cceditbox to winrt #5805/files#diff-10 (43)
• M samples/Cpp/TestCpp/proj.winrt/MainPage.xaml.hhttps://github.com/closed #4163: add cceditbox to winrt #5805/files#diff-11 (2)
• M samples/Cpp/TestCpp/proj.winrt/TestCpp.vcxprojhttps://github.com/closed #4163: add cceditbox to winrt #5805/files#diff-12 (19)
• M samples/Cpp/TestCpp/proj.winrt/TestCpp.vcxproj.filtershttps://github.com/closed #4163: add cceditbox to winrt #5805/files#diff-13 (35)

Patch Links:

• https://github.com/cocos2d/cocos2d-x/pull/5805.patch
• https://github.com/cocos2d/cocos2d-x/pull/5805.diff

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/5805.

[squirrelChen]

@stammen no problem,Take your time -- there is no rush.

[dumganhar]

This Pr could not be automatically merged.

[squirrelChen]

can auto merged now.

[JoelOliv]

anyone have any idea when you will do the merge

[toryxu]

@stammen can you please help review? then we can start to merge it. Thanks.

[stammen]

Good job on the code! The code builds and runs in the cocos2d-winrt.vc2012.sln project but not the cocos2d-winrt.vc2013.sln winrt project. Please fix and test the VS2013 project by adding the missing files. Also, please verify that ARM versions build correctly.