Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand docstrings, fix typos, fix paths. #1018

Closed
wants to merge 5 commits into from
Closed

Expand docstrings, fix typos, fix paths. #1018

wants to merge 5 commits into from

Conversation

cmarqu
Copy link
Contributor

@cmarqu cmarqu commented Jul 14, 2019

Refs #811.

eric-wieser
eric-wieser reviewed Jul 14, 2019
View reviewed changes
tests/test_cases/test_cocotb/test_cocotb.py Show resolved Hide resolved
cocotb/triggers.py Outdated Show resolved Hide resolved
imphil
imphil requested changes Jul 16, 2019
View reviewed changes
Copy link
Member

@imphil imphil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmarqu! Can you have a second look at the install section?

documentation/source/quickstart.rst Outdated Show resolved Hide resolved
@imphil
Copy link
Member

imphil commented Jul 17, 2019

Please rebase this on top of master to incorporate the changes done by Eric.

@themperek themperek requested a review from imphil August 15, 2019 18:30
@eric-wieser
Copy link
Member

@imphil: Good to go?

@imphil
Copy link
Member

imphil commented Aug 26, 2019

Manually rebased and merged.

@imphil imphil closed this Aug 26, 2019
@imphil imphil added this to the 1.3 milestone Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@imphil imphil Awaiting requested review from imphil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@cmarqu @imphil @eric-wieser