-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XCELIUM to existing IUS define checks. #1074
Conversation
Is not better to just keep one in the define (across the code)? |
I thought about this but didn't like it so much - it then has some magic going on behind the scenes, instead of the current straightforward Of course, I'm open to change this if normalizing to a single define is the mainstream opinion. |
The normalization could happen in the c preprocessor. Is there a name that covers both of these? |
|
For Questa we keep MODELSIM do not see why we cannot do the same here. |
d9fb863
to
e0c3300
Compare
Alright, I now used the method of the existing ModelSim/Questa normalization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is the cleanest approach, but it's what we already do, and consistency is probably more important
For some reason I missed to also check for the
XCELIUM
define when I introducedMakefile.xcelium
, fix that.