Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group all trivy files in a new language #77

Closed
wants to merge 4 commits into from
Closed

Group all trivy files in a new language #77

wants to merge 4 commits into from

Conversation

DMarinhoCodacy
Copy link

No description provided.

@lolgab
Copy link
Contributor

lolgab commented Nov 21, 2023

Be careful with this change as it can break Codacy.
First of all, you are using the concept of language to express something like TrivyFile which is arguably not a language.
Then you are adding package.json to this language and removing from Json which is the natural place it belongs to.

What do you want to achieve exactly?

Are you aware of the process documented here? https://codacy.slite.com/app/docs/UCT91ruiVn9tTh

@DMarinhoCodacy
Copy link
Author

We need to rethink this approach. Closing this PR.

@afsmeira afsmeira deleted the add-new-language-trivy branch October 3, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanvacareanu7 stefanvacareanu7 stefanvacareanu7 left review comments

@mrfyda mrfyda Awaiting requested review from mrfyda

@lolgab lolgab Awaiting requested review from lolgab

@codacy-vrhpires codacy-vrhpires Awaiting requested review from codacy-vrhpires

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DMarinhoCodacy @lolgab @stefanvacareanu7