forked from kestasjk/webDiplomacy
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fbfw 53 device viewports and more #15
Merged
bryancodazen
merged 5 commits into
staging
from
feature/fbfw-53-device-viewports-and-more
Feb 11, 2022
Merged
Feature/fbfw 53 device viewports and more #15
bryancodazen
merged 5 commits into
staging
from
feature/fbfw-53-device-viewports-and-more
Feb 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…webDiplomacy into feature/fbfw-28-mui-dialog
…hich has a powerful API to help us control the SVG. Added panning and zooming ability as well as boundaries so that the user can only navigate within the map. When adjusting the viewport (such as during a resize or when tilting your phone) there is a debounced function which will adjust the map and associated scales and values. Every device has zooming limits and initial zooms to approximate the mocks. Did a quick breakup of the SVG currently being used into components (these are not meant to be the final components for breaking up the SVG).
…lder. Re-built the beta dir
bryancodazen
requested review from
hyukcodazen,
jchoi166,
nebevets and
sariacodazen
February 10, 2022 00:59
nebevets
reviewed
Feb 10, 2022
nebevets
reviewed
Feb 10, 2022
nebevets
reviewed
Feb 10, 2022
nebevets
reviewed
Feb 10, 2022
nebevets
reviewed
Feb 10, 2022
nebevets
reviewed
Feb 10, 2022
nebevets
reviewed
Feb 10, 2022
nebevets
reviewed
Feb 10, 2022
nebevets
reviewed
Feb 10, 2022
nebevets
reviewed
Feb 10, 2022
nebevets
reviewed
Feb 10, 2022
nebevets
reviewed
Feb 10, 2022
nebevets
reviewed
Feb 10, 2022
nebevets
reviewed
Feb 10, 2022
nebevets
reviewed
Feb 10, 2022
nebevets
reviewed
Feb 10, 2022
nebevets
reviewed
Feb 10, 2022
nebevets
reviewed
Feb 10, 2022
nebevets
reviewed
Feb 10, 2022
…ok. Made Device an enum. Removed redundant preserveAspectRatio from SVG. Removed shadow-off and added eslint-typescript shadow off rule.
nebevets
approved these changes
Feb 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, my only concern is the eslintrc changes.
}; | ||
|
||
return [viewport, setViewport]; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Test Plan
localhost/beta
https://drive.google.com/file/d/1Q2hVA_yXlM9jrq3RaSRP5EOmjwHY-sE4/view?usp=sharing