Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing playback speed with a hotkey does not work reliably #2166

Closed
andraz opened this issue Apr 8, 2024 · 6 comments
Closed

Changing playback speed with a hotkey does not work reliably #2166

andraz opened this issue Apr 8, 2024 · 6 comments
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@andraz
Copy link

andraz commented Apr 8, 2024

BUG: Playback hotkeys only work sometimes.
⚬ Browser: Chrome
HOW:

  1. map playback speed to two keyboard buttons (in my case , and . on SI keyboard, they would be < and > in US)
  2. after refreshing the YouTube page, buttons work and increase/decrease playback speed
  3. but after some navigation or even just changing the system volume with a keyboard volume button, they stop working
  4. refreshing the page fixes the issue

Might be related to #2046 and #664 (my buttons are identical to the built in speed hotkeys without shift, but the YT built in buttons work only up to 2x so they are practically useless - alternative fix might be to remove this limitation, to allow built in hotkeys to work correctly up to 16x)

@andraz andraz added Bug Bug or required update after YouTube changes Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Apr 8, 2024
@ImprovedTube
Copy link
Member

ImprovedTube commented Apr 11, 2024

thanks! @andraz
is this true for our other shortcuts too?

everything about our shortcuts: #1565
(hopefully this motivates somebody to understand the whole script)

@ImprovedTube ImprovedTube removed the Feature request Wish or idea label Apr 11, 2024
@andraz
Copy link
Author

andraz commented Apr 11, 2024

No, it seems J and L continue to work fine, but speed hotkeys break after I change system volume with my media keys.

I did figure out I can fix this by CTRL+1..9 or CTRL+TAB to switch tabs away and back to the YouTube player.

After this workaround, hotkeys work again (until I break them again with volume change). This can be replicated multiple times.

@ImprovedTube
Copy link
Member

fascinating!

@ImprovedTube
Copy link
Member

no wait, since J & L are youtube defaults, my original question remain. also check the browser console, please. and logging out of youtube maybe

@andraz
Copy link
Author

andraz commented Apr 12, 2024

Tested again with extra keys for skipping chapters back and forward linked to B and N.

They fail in the same way as speed buttons and can be fixed in same way, by switching tab focus away and back.

p.s.: checked console, no messages when broken or when fixed back to working state

@raszpl
Copy link
Contributor

raszpl commented Jun 29, 2024

Tested again with extra keys for skipping chapters back and forward linked to B and N.

They fail in the same way as speed buttons and can be fixed in same way, by switching tab focus away and back.

looks like one of shortcuts bugs I just fixed, code wasnt keeping track of pressed keys well and losing events #2421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

3 participants