Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-ajax to the latest version 馃殌 #1261

Merged
merged 1 commit into from May 8, 2017

Conversation

greenkeeper[bot]
Copy link

@greenkeeper greenkeeper bot commented Apr 22, 2017

Version 3.0.0 of ember-ajax just got published.

Dependency ember-ajax
Current Version 2.5.6
Type devDependency

The version 3.0.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of ember-ajax.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Release Notes Make it Simple(r)

Breaking Changes

Simplifying normalizeErrorResponse

After much discussion, the team around ember-ajax decided that it was probably not a great idea to reformat the error payload to match some arbitrary format that we designed. Instead, we should just use the payload that the server returned.

If you want to maintain the old behavior, you can include the the legacy/normalize-error-response mixin, which has the old version of the method included and will override the new behavior.

// app/services/ajax.js
import AjaxService from 'ember-ajax/services/ajax';
import LegacyNormalizeErrorResponse from 'ember-ajax/mixins/legacy/normalize-error-response';

export default AjaxService.extends(LegacyNormalizeErrorResponse, {
// Your other configuration here
});

Replacing AjaxError.errors with AjaxError.payload

The errors property on any AjaxError subclass has been deprecated in favor of a payload property for a while now. If you want access to the response from the server, you should now use the payload property, like so:

return this.get('ajax').request('/posts')
  .then((posts) => {
    // Do something with your posts
  })
  .catch((error) => {
    this.displayError(error.payload); // `error.payload` will be whatever the server responded with
  });

No longer modify null or undefined server response (#232)

If your server response is interpreted by jQuery#ajax to be null or undefined, we will resolve that value, instead of turning it into an empty object.

Commits

The new version differs by 49 commits ahead by 49, behind by 7.

  • 2aba19e Released v3.0.0
  • 5c6a45a Upgrade dependencies (#283)
  • acd384f fix(package): update ember-cli-babel to version 6.0.0-beta.10 (#277)
  • c70bc9a Update to use Babel 6 (#266)
  • 528e843 Upgrade ember-resolver to 4.1.0
  • 4181656 Released v3.0.0-beta.1
  • 86ab8d0 Fix issues with the isString helper
  • 723dd66 Tighten ESLint config
  • 78de692 Hide container by default when running tests
  • ac023c1 Slight cleanup of JSON test helper
  • 60cb8de make sure contentType is a string before running a regex match (#250)
  • 4e784a2 Released v3.0.0-beta.0
  • fe03044 Released v2.5.7-beta.0
  • db086b3 Released v2.5.7
  • 1f4ca9d Simplify normalizeErrorResponse (#265)

There are 49 commits in total.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 馃尨

@begedin begedin force-pushed the greenkeeper/ember-ajax-3.0.0 branch from 44af7b3 to 450f777 Compare May 8, 2017 13:18
@begedin begedin merged commit 93d7c87 into develop May 8, 2017
@begedin begedin deleted the greenkeeper/ember-ajax-3.0.0 branch May 8, 2017 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant