Add conversation mirage setup and remove un-needed mirage models #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsmith
reviewed
Dec 26, 2017
config/environment.js
Outdated
| @@ -173,6 +173,7 @@ module.exports = function(environment) { | |||
| ENV['simple-auth'] = { | |||
| store: 'simple-auth-session-store:ephemeral' | |||
| }; | |||
| ENV.SOCKETS_BASE_URL = ''; | |||
There was a problem hiding this comment.
Could we add this between API/WEB?
| return moment().subtract(i, 'days'); | ||
| } | ||
| // author: belongsTo('user', { async: true }), | ||
| // conversation: belongsTo('conversation', { async: true }) |
There was a problem hiding this comment.
You can remove these two lines.
mirage/models/conversation.js
Outdated
| message: belongsTo(), | ||
| user: belongsTo(), | ||
| conversationParts: hasMany() | ||
| }); |
There was a problem hiding this comment.
Why is this being removed?
There was a problem hiding this comment.
miragejs/ember-cli-mirage#1056
So mirage can auto generate mirage models based off of the ember-data model, avoiding mismatches b/w the two.
Lmk what you think? We can keep slowly removing these as needed or all of them in a separate PR.
There was a problem hiding this comment.
Ah okay thanks. Maybe open a separate issue so others are tracking that’s the case as a point of reference?
snewcomer
force-pushed
the
mirage-conversation
branch
2 times, most recently
from
532d5b3
to
f56e779
Compare
begedin
approved these changes
Jan 3, 2018
snewcomer
force-pushed
the
mirage-conversation
branch
from
a64a355
to
f56e779
Compare
snewcomer
force-pushed
the
mirage-conversation
branch
from
f56e779
to
0d80e3f
Compare
|
@snewcomer want to squash and merge when you're ready? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting something showing in 4200 land.
Another note/question is if we want mirage to auto-detect the model, thus removing the need to define a mirage model (got in version 0.3.2 I think). Lmk if that is something you want me to remove if the mirage model isn't needed.