Skip to content

Commit

Permalink
Merge pull request #20943 from code-dot-org/log-main-json-source-url
Browse files Browse the repository at this point in the history
also log sourceUrl as it appears in main.json
  • Loading branch information
davidsbailey committed Feb 28, 2018
2 parents 941b024 + 0e53cd2 commit 5cb89f3
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
4 changes: 2 additions & 2 deletions apps/src/gamelab/ErrorDialogStack.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class ErrorDialogStack extends React.Component {
'analysis-events',
{
study: 'animation_no_load',
study_group: 'animation_no_load_v3',
study_group: 'animation_no_load_v4',
event: 'delete_selected',
project_id: getCurrentId(),
data_json: JSON.stringify({'version': this.props.animationList.propsByKey[key].version,
Expand All @@ -48,7 +48,7 @@ class ErrorDialogStack extends React.Component {
'analysis-events',
{
study: 'animation_no_load',
study_group: 'animation_no_load_v3',
study_group: 'animation_no_load_v4',
event: 'reload_selected',
project_id: getCurrentId(),
data_json: JSON.stringify({'version': this.props.animationList.propsByKey[key].version,
Expand Down
11 changes: 8 additions & 3 deletions apps/src/gamelab/animationListModule.js
Original file line number Diff line number Diff line change
Expand Up @@ -570,11 +570,16 @@ function loadAnimationFromSource(key, callback) {
'analysis-events',
{
study: 'animation_no_load',
study_group: 'animation_no_load_v3',
study_group: 'animation_no_load_v4',
event: isOwner() ? 'animation_not_loaded_owner' : 'animation_not_loaded_viewer',
project_id: getCurrentId(),
data_json: JSON.stringify({'sourceUrl': sourceUrl, 'version': state.propsByKey[key].version,
'animationName': state.propsByKey[key].name, 'error': err.message})
data_json: JSON.stringify({
'sourceUrl': sourceUrl,
'mainJsonSourceUrl': state.propsByKey[key].sourceUrl,
'version': state.propsByKey[key].version,
'animationName': state.propsByKey[key].name,
'error': err.message
})
},
{includeUserId: true}
);
Expand Down

0 comments on commit 5cb89f3

Please sign in to comment.