Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also log sourceUrl as it appears in main.json #20943

Merged
merged 3 commits into from Feb 28, 2018

Conversation

davidsbailey
Copy link
Member

Background

The "animation not loaded" logging gives us lots of great info, but does not currently provide us with enough to determine if any of the animations have a bad source URL. this is because the existing sourceUrl field is the url used to display the image in Game Lab, whereas the field we need to determine this is the sourceUrl as it appears in main.json.

Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@davidsbailey davidsbailey merged commit 5cb89f3 into staging Feb 28, 2018
@davidsbailey davidsbailey deleted the log-main-json-source-url branch February 28, 2018 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants