Merge pull request #38441 from code-dot-org/increase-account-purge-limit

Increased the safety limit of the deleted account purger

dashboard/lib/expired_deleted_account_purger.rb

@@ -53,9 +53,9 @@ def initialize(options = {})
     # Do nothing if more than this number of accounts would be purged in total.
     # We may need to adjust this over time as activity increases on our site.
     # This is a loose constraint because cascading student deletes make this a very spiky metric.
-    # 4000 is ~0.01% of our user rows.
-    # We expect this to stay below 1500 during September 2018.
-    @max_accounts_to_purge = options[:max_accounts_to_purge] || 4000
+    # 8000 is ~0.01% of our user rows in 2021. We expect this to stay below 2000 during regular
+    # months and 5000 during the HOC week purge (1st week of Jan).
+    @max_accounts_to_purge = options[:max_accounts_to_purge] || 8000
     raise ArgumentError.new('max_accounts_to_purge must be Integer') unless @max_accounts_to_purge.is_a? Integer
 
     reset

dashboard/test/lib/expired_deleted_account_purger_test.rb

@@ -37,7 +37,7 @@ def teardown
     assert_equal 60.days.ago, edap.deleted_after
     assert_equal 28.days.ago, edap.deleted_before
     assert_equal 200, edap.max_teachers_to_purge
-    assert_equal 4000, edap.max_accounts_to_purge
+    assert_equal 8000, edap.max_accounts_to_purge
   end
 
   test 'raises ArgumentError unless dry_run is boolean' do