Increased the safety limit of the deleted account purger #38441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmkulwik
requested review from
bencodeorg,
cforkish,
hacodeorg,
sureshc and
daynew
bencodeorg
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Jan 6, 2021. We exceeded our account purge safety limit of 4k. This limit was set back in 2018 when 4k was 0.01% of our 40,000,000 users. Now, we have ~74,000,000 users. Given that we were cleaning up accounts deleted during HOC week, and our usage has increased significantly since 2018, we should increase the limit to account for this increased usage. The new limit is being set to 8k to give us some breathing room.
Additional details: https://codedotorg.slack.com/archives/C3S8AJY9K/p1609954472004100
Links
Testing story
Reviewer Checklist: