survey: Return survey results for single-page assessments too. #12299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this meant to be |
|
LGTM but echoing Asher's comments - this should be against staging-next |
|
should there be a corresponding change to unit tests for this? |
pcardune
reviewed
Dec 8, 2016
| @@ -360,6 +360,113 @@ def make_progress_in_section(script) | |||
| assert_equal expected_response, JSON.parse(@response.body) | |||
| end | |||
|
|
|||
| test "should get surveys for section with script with single page anonymous level_group assessment" do | |||
With the change to make level groups with pages "long assessments" even if they have a single page, we could no longer have a stage in allthethings.script that had two of these. The single page assessment is moved to a new stage. Also, some improvements were made to the tests to make them run more reliably on localhost with Chromedriver.
breville
commented
Dec 9, 2016
| @@ -767,10 +767,11 @@ def generate_teacher_student(name, teacher_authorized) | |||
| steps %Q{ | |||
| Then I am on "http://code.org/teacher-dashboard#/sections" | |||
| And I wait to see ".jumbotron" | |||
| And I wait for 3 seconds | |||
There was a problem hiding this comment.
@Bjvanminnen I made a few changes that seemed to help here.
breville
commented
Dec 9, 2016
| @@ -767,10 +767,11 @@ def generate_teacher_student(name, teacher_authorized) | |||
| steps %Q{ | |||
| Then I am on "http://code.org/teacher-dashboard#/sections" | |||
| And I wait to see ".jumbotron" | |||
| And I wait for 3 seconds | |||
| And I click selector ".btn-white:contains('New section')" once I see it | |||
There was a problem hiding this comment.
@Bjvanminnen Any idea why a 3 second delay is needed despite having once I see it here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.