Fix some bad assumptions in playlab blocks #13369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namely, the assumption that our definition of skin will always be fully-formed, with all the fields of all the types that we expect. This assumption is valid in all of our Code Studio environments, but fails in levelbuilder, where we initialize simple readonly blockspaces to display block previews. This assumption has been failing for a while, but for most of that time this code was being loaded async, so when it broke it didn't break any of the other javascript on the page. A recent change altered that, revealing this problem.
balderdash
approved these changes
Feb 22, 2017
apps/src/studio/paramLists.js
Outdated
|
|
||
| if (level && level.paramRestrictions) { | ||
| var restrictions = level.paramRestrictions && level.paramRestrictions.playSound; | ||
| if (restrictions) { |
There was a problem hiding this comment.
I think these two if statements can be combined into one triple null check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely, the assumption that our definition of skin will always be
fully-formed, with all the fields of all the types that we expect. This
assumption is valid in all of our Code Studio environments, but fails in
levelbuilder, where we initialize simple readonly blockspaces to display
block previews.
This assumption has been failing for a while, but for most of that time
this code was being loaded async, so when it broke it didn't break any
of the other javascript on the page. A recent change altered that,
revealing this problem.