Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some bad assumptions in playlab blocks #13369

Merged
merged 2 commits into from
Feb 23, 2017
Merged

Fix some bad assumptions in playlab blocks #13369

merged 2 commits into from
Feb 23, 2017

Commits on Feb 22, 2017

  1. Fix some bad assumptions in playlab blocks 

    Namely, the assumption that our definition of skin will always be
fully-formed, with all the fields of all the types that we expect. This
assumption is valid in all of our Code Studio environments, but fails in
levelbuilder, where we initialize simple readonly blockspaces to display
block previews.

This assumption has been failing for a while, but for most of that time
this code was being loaded async, so when it broke it didn't break any
of the other javascript on the page. A recent change altered that,
revealing this problem.
    @Hamms
    Hamms committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    c34c5fc View commit details
    Browse the repository at this point in the history

  2. compress new conditional and old conditional into one

    @Hamms
    Hamms committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    bd5a0e4 View commit details
    Browse the repository at this point in the history